refactor(deps): removing fbjs dependency by creating a local module for invariant and warning #2727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #2333,
invariantandwarningare the last two dependencies in the project used fromfbjsand removing them allows removing that external dependency.In this PR:
invariantand replacing the importswarningwhich had another dependency ofemptyFunctionhence it has been added as well.fbjsdependency has been removed frompackages/react-native-web/package.json.I can still see
fbjsin the mainpackage-lock.jsonas there are other packages within the repo that havereact-native-webinstalled as a dependency, hence it might potentially be removed once that dependency is upgraded as well.Ps: I did the replacement of
warningin the same PR as it was fairly small, but happy to split this up in another PR if needed.