Fix Java two-stack solution article on minimum-stack.md#5658
Open
edd-1701 wants to merge 2 commits intoneetcode-gh:mainfrom
Open
Fix Java two-stack solution article on minimum-stack.md#5658edd-1701 wants to merge 2 commits intoneetcode-gh:mainfrom
edd-1701 wants to merge 2 commits intoneetcode-gh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code sample as-is does not pass.
Equality for non-primitive
Integerobjects should be checked with.equals()==is otherwise checking the reference is to the same objectJava has a pitfall where it caches (and reuses) small Integers (-128 to 127) by default. This can make you think
==is working as expected.