PLAN-2443 - Include allReduce in the Pattern docs where QPPs are described #1407
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blouerat
reviewed
Oct 24, 2025
Comment on lines
565
to
566
| An alternative is to use the information that we want to find paths with a total distance less than `6.05`. | ||
| From the `ALL SHORTEST` query, we know that there exists a path with a total distance of `6.04`. |
There was a problem hiding this comment.
I would avoid mentioning SHORTEST here, it muddies the water. We don't want to suggest the association of SHORTEST with allReduce().
Like in the previous example we say "This works fine where the solution is known to lie within some range of hops.", here I would say that I pick a known upper bound of 6.05 or maybe even 7 or 10 for the total distance. I wouldn't specify how I know it to be a reasonable upper bound.
| * Nodes or relationships must have properties satisfying some condition. | ||
| For example, all relationships must have the property `distance > 10`. | ||
|
|
||
| * For every iteration of the QPP, an aggregated value over the constructed path so far should satisfy a predicate. |
There was a problem hiding this comment.
Suggested change
| * For every iteration of the QPP, an aggregated value over the constructed path so far should satisfy a predicate. | |
| * For every iteration of the quantified path pattern, an aggregated value over the constructed path so far should satisfy a predicate. |
| | *Syntax* 3+| `allReduce(accumulator = initial, stepVariable IN list \| reductionFunction, predicate)` | ||
| | *Description* 3+| Returns true if, during the stepwise evaluation of a value across the elements in a given `LIST<ANY>`, the accumulated result satisfies a specified predicate at every step. | ||
| Where that list is a xref:patterns/variable-length-patterns.adoc#group-variables[group variable] defined in a xref:patterns/variable-length-patterns.adoc#quantified-path-patterns[quantified path pattern], it allows for the early pruning of paths that do not satisfy the predicate. | ||
| Where that list is a xref:patterns/variable-length-patterns.adoc#group-variables[group variable] defined in a xref:patterns/variable-length-patterns.adoc#quantified-path-patterns[quantified path pattern] (not within a xref:patterns/shortest-paths.adoc[shortest path pattern]), it allows for the early pruning of paths that do not satisfy the predicate. |
There was a problem hiding this comment.
I would make it a bit longer and as a follow-up sentence, not between prentheses.
|
This PR includes documentation updates Updated pages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.