Skip to content

Fix: Typing works again in Variables Editor #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2025
Merged

Fix: Typing works again in Variables Editor #650

merged 3 commits into from
Aug 4, 2025

Conversation

mjfwebb
Copy link
Contributor

@mjfwebb mjfwebb commented Jul 11, 2025 •
edited
Loading

  • Replaced useEffect with useMount in VariablesEditor for better lifecycle management.
  • Added a new test suite variableseditor.test.ts to validate the functionality of the variables editor, including verifying typed variables and JSON prettification.
  • Introduced a test in queryeditortabs.test.ts to ensure the query editor displays typed queries correctly.

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Jul 11, 2025 •
edited
Loading

Thanks for the Neo4j GraphQL Toolbox updates.

The Neo4j GraphQL Toolbox has now been torn down - reopening this PR will republish it.

Liam-Doodson
Liam-Doodson requested changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@Liam-Doodson Liam-Doodson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this out but I still can't type more that 1 character in the variables editor 🫤

@mjfwebb mjfwebb merged commit 971b7bc into dev Aug 4, 2025
10 checks passed
@mjfwebb mjfwebb deleted the fix/edit-parameters branch August 4, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liam-Doodson Liam-Doodson Liam-Doodson requested changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjfwebb @neo4j-team-graphql @Liam-Doodson