Skip to content

Limit @apollo/subgraph to below 2.15 to fix getSubgraphSchema (lts) - #7392

Open
mjfwebb wants to merge 7 commits into
ltsfrom
lts-apollo-subgraph-2.15
Open

mjfwebb wants to merge 7 commits into
ltsfrom
lts-apollo-subgraph-2.15

Conversation

@mjfwebb

@mjfwebb mjfwebb commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

getSubgraphSchema() throws on a fresh install of 5.12.15. Our ^2.2.3 range now pulls in @apollo/subgraph 2.15, which removed the { typeDefs, resolvers } input we pass it:

TypeError: doc.definitions is not iterable
  • Limit @apollo/subgraph to >=2.2.3 <2.15.0, because 2.15 needs Node.js 22+ and graphql 16.11+.
  • Pin @graphql-tools/utils to 12.1.0 (was 11.0.1), so our IResolvers type matches the one from @graphql-tools/schema 10.1. 12.1.0 is the lowest version @graphql-tools/schema 10.1.5 accepts.

For reference, lts (5.x) declares "engines": { "node": ">=16.0.0" } and a graphql peer range of ^16.0.0 in packages/graphql/package.json. We can't raise those on lts, so it can't take 2.15.

No source changes. A fresh install of the packed build resolves @apollo/subgraph 2.14.4, and getSubgraphSchema() works. The schema snapshots don't change.

Complexity

Complexity: Low

Issue

Unblocks the lock file maintenance PR #7365, and replaces the Renovate security PR #7389 (GHSA-7mx3-vvmw-hjmv). #7393 fixes dev, where 2.15 is allowed.

Checklist

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

@mjfwebb
mjfwebb requested a review from a team as a code owner October 20, 2026 15:44
@mjfwebb
mjfwebb requested a review from vivientran42 October 20, 2026 15:44
@changeset-bot

changeset-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a3cf4fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mjfwebb
mjfwebb requested review from risset and removed request for vivientran42 October 20, 2026 15:45
@mjfwebb mjfwebb changed the title Support @apollo/subgraph 2.15 and @graphql-tools/utils 12 (lts) Fix getSubgraphSchema crash with @apollo/subgraph 2.15 (lts) Oct 20, 2026
@mjfwebb mjfwebb changed the title Fix getSubgraphSchema crash with @apollo/subgraph 2.15 (lts) Limit @apollo/subgraph to below 2.15 to fix getSubgraphSchema (lts) Oct 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant