Add integration test framework - #127
Open
mezz wants to merge 17 commits into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic integration tests to the project, as a foundation for future changes or optimizations.
It's kind of big because I needed to write a bunch of builders to make the tests readable. I tried to add tests for basic functionality, to show that both the current code and the integration test builders are working correctly.
For the review, it's probably best to just read the actual tests for correctness, and then see if there's some obvious flaw in the builder.
I think the main weakness of some of these tests is that they check the output logs, for example to see if things were cached or not. We could probably harden that but for now I think we can just update the tests if we change those log strings.
There is only one real minor code fix in here,
in
src/main/java/net/neoforged/neoform/runtime/actions/ApplySourceTransformAction.javato set absolute paths. It is tested with an integration testSourceTransformIntegrationTest #appliesAccessTransformerPaths