Skip to content

Fix issue: #3532: Disconnect issue with CompressedSpikes:ON/Off #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Fix issue: #3532: Disconnect issue with CompressedSpikes:ON/Off #3536

wants to merge 17 commits into from

Conversation

med-ayssar
Copy link
Contributor

Fix for #3532

@med-ayssar med-ayssar changed the title Fix issue: #3532: Disconnect given compressedSpikes Fix issue: #3532: Disconnect issue with CompressedSpikes:ON/Off Jul 20, 2025
@gtrensch gtrensch added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority labels Jul 25, 2025
@gtrensch gtrensch added this to Kernel Jul 25, 2025
@github-project-automation github-project-automation bot moved this to In progress in Kernel Jul 25, 2025
@heplesser heplesser added S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) and removed S: Normal Handle this with default priority labels Aug 7, 2025
@heplesser
Copy link
Contributor

@med-ayssar Thanks for your detective work and the PR! I will look at it in detail asap.

heplesser
heplesser requested changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@med-ayssar Thanks for the PR! I am not entirely sure I follow the logic around nth_equal(), see comments below.

I also wonder if, for the uncompressed case, we should not take a different approach. In that case, I believe, we simply need to run through all connections of a given synapse type linearly and disconnect the first one for which source and target match, and which has not yet been disconnected. I guess that means parallel iteration through source and target tables. The split into find_first_source() and find_first_target() does not make sense in that case.

We also need some tests, including tests where there are multiple connections between the same source-target pair and we delete one at a time.

@github-project-automation github-project-automation bot moved this from In progress to PRs pending approval in Kernel Aug 8, 2025
@med-ayssar
Copy link
Contributor Author

@heplesser: Is it possible to setup a meeting to discuss this? Any time after 17:30 should work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanVogelsang JanVogelsang Awaiting requested review from JanVogelsang

@heplesser heplesser Awaiting requested review from heplesser

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Kernel
Status: PRs pending approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@med-ayssar @heplesser @gtrensch