fix(typeorm): Warning log when multiple DataSources have the same name #2461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added null/undefined checks in validateDataSourceNames to avoid TypeError. - Improved logging for duplicate DataSource names - Added edge case tests (null, undefined, default name, multiple duplicates, empty array), all passed
Author
|
For a better fix, I would suggest taking a unique Id for each Data Source connected and assigning it accordingly. This would require making the Id Map class scoped and tracks the instances to assign new names accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Multiple Data Sources could have had the same name, and no logs to warn about this issue.
Issue Number: #2017
What is the new behavior?
The TypeOrmCore now checks the current name pool using a static Map, and if duplicates where found a comprehensive warning would be logged.
Does this PR introduce a breaking change?
Other information