Skip to content

add esg support for set rules #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add esg support for set rules #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions aci_tenants.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2510,6 +2510,9 @@ locals {
external_endpoint_group = try(policy.external_endpoint_group.name, null) != null ? "${policy.external_endpoint_group.name}${local.defaults.apic.tenants.l3outs.external_endpoint_groups.name_suffix}" : ""
external_endpoint_group_l3out = try(policy.external_endpoint_group.l3out, null) != null ? "${policy.external_endpoint_group.l3out}${local.defaults.apic.tenants.l3outs.name_suffix}" : ""
external_endpoint_group_tenant = try(policy.external_endpoint_group.tenant, tenant.name)
endpoint_security_group = try(policy.endpoint_security_group.name, null) != null ? "${policy.endpoint_security_group.name}${local.defaults.apic.tenants.application_profiles.name_suffix}" : ""
endpoint_security_group_app = try(policy.endpoint_security_group.app, null) != null ? "${policy.endpoint_security_group.app}${local.defaults.apic.tenants.application_profiles.endpoint_security_groups.name_suffix}" : ""
endpoint_security_group_tenant = try(policy.endpoint_security_group.tenant, tenant.name)
}
]
])
Expand Down Expand Up @@ -2542,6 +2545,9 @@ module "aci_set_rule" {
external_endpoint_group = each.value.external_endpoint_group
external_endpoint_group_l3out = each.value.external_endpoint_group_l3out
external_endpoint_group_tenant = each.value.external_endpoint_group_tenant
endpoint_security_group = each.value.endpoint_security_group
endpoint_security_group_app = each.value.endpoint_security_group_app
endpoint_security_group_tenant = each.value.endpoint_security_group_tenant

depends_on = [
module.aci_tenant,
Expand Down
11 changes: 10 additions & 1 deletion modules/terraform-aci-set-rule/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ resource "aci_rest_managed" "rtctrlSetRedistMultipath" {
}

resource "aci_rest_managed" "rtctrlSetPolicyTag" {
count = var.external_endpoint_group != "" && var.external_endpoint_group_l3out != "" ? 1 : 0
count = var.external_endpoint_group != "" && var.external_endpoint_group_l3out != "" || var.endpoint_security_group != "" && var.endpoint_security_group_app != "" ? 1 : 0
dn = "${aci_rest_managed.rtctrlAttrP.dn}/sptag"
class_name = "rtctrlSetPolicyTag"
content = {
Expand All @@ -177,3 +177,12 @@ resource "aci_rest_managed" "rtctrlRsSetPolicyTagToInstP" {
"tDn" = "uni/tn-${try(var.external_endpoint_group_tenant, var.tenant)}/out-${var.external_endpoint_group_l3out}/instP-${var.external_endpoint_group}"
}
}

resource "aci_rest_managed" "rtctrlRsSetPolicyTagToESg" {
count = var.endpoint_security_group != "" && var.endpoint_security_group_app != "" ? 1 : 0
dn = "${aci_rest_managed.rtctrlSetPolicyTag[0].dn}/rssetPolicyTagToESg"
class_name = "rtctrlRsSetPolicyTagToESg"
content = {
"tDn" = "uni/tn-${try(var.endpoint_security_group_tenant, var.tenant)}/ap-${var.endpoint_security_group_app}/esg-${var.endpoint_security_group}"
}
}
38 changes: 38 additions & 0 deletions modules/terraform-aci-set-rule/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,41 @@ variable "external_endpoint_group_tenant" {
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
}
}

// ESG Support
variable "endpoint_security_group" {
description = "Endpoint Security group name."
type = string
default = ""

validation {
condition = can(regex("^[a-zA-Z0-9_.:-]{0,64}$", var.endpoint_security_group))
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
}
validation {
condition = !(var.external_endpoint_group != "" && var.endpoint_security_group != "")
error_message = "Cannot specify both external_endpoint_group and endpoint_security_group. Only one can be configured."
}
}

variable "endpoint_security_group_app" {
description = "Endpoint security group app name."
type = string
default = ""

validation {
condition = can(regex("^[a-zA-Z0-9_.:-]{0,64}$", var.endpoint_security_group_app))
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
}
}

variable "endpoint_security_group_tenant" {
description = "Endpoint security group tenant name."
type = string
default = ""

validation {
condition = can(regex("^[a-zA-Z0-9_.:-]{0,64}$", var.endpoint_security_group_tenant))
error_message = "Allowed characters: `a`-`z`, `A`-`Z`, `0`-`9`, `_`, `.`, `:`, `-`. Maximum characters: 64."
}
}
Loading