Skip to content

Fixes #20551: Support quick-add form prefix in automatic slug generation #20624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
+24 −6
Merged

Fixes #20551: Support quick-add form prefix in automatic slug generation #20624

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e5db95
Fixes #20551: Support quick-add form prefix in automatic slug generation
jnovinger Oct 19, 2025
2803b18
Address PR feedback
jnovinger Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netbox/project-static/dist/netbox.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions netbox/project-static/dist/netbox.js.map
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 9 additions & 2 deletions netbox/project-static/src/buttons/reslug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,17 @@ export function initReslug(): void {
for (const slugButton of getElements<HTMLButtonElement>('button#reslug')) {
const form = slugButton.form;
if (form == null) continue;
const slugField = form.querySelector('#id_slug') as HTMLInputElement;

// Try without prefix first, fallback to quickadd prefix for quick-add modals
const slugField = (form.querySelector('#id_slug') ??
form.querySelector('#id_quickadd-slug')) as HTMLInputElement;
if (slugField == null) continue;

const sourceId = slugField.getAttribute('slug-source');
const sourceField = form.querySelector(`#id_${sourceId}`) as HTMLInputElement;

// Try both patterns for source field as well
const sourceField = (form.querySelector(`#id_${sourceId}`) ??
form.querySelector(`#id_quickadd-${sourceId}`)) as HTMLInputElement;

const slugLengthAttr = slugField.getAttribute('maxlength');
let slugLength = 50;
Expand Down