fix: disable tags in Setting model #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
Setting
model in thenetbox_diode_plugin
by explicitly disabling thetags
attribute, and adds a corresponding test to ensure this behavior. Tags are not needed in this model (which extendsNetBoxModel
) and cause reverse accessor conflicts with other Setting models (e.g. defined in other NetBox plugins)Testing improvements:
test_tags_disabled
innetbox_diode_plugin/tests/test_models.py
to verify that thetags
attribute on theSetting
model is disabled (set toNone
).Model update:
tags
attribute toNone
in theSetting
model withinnetbox_diode_plugin/models.py
to disable tagging for this model.