Skip to content

Conversation

mfiedorowicz
Copy link
Member

This pull request makes a small change to the Setting model in the netbox_diode_plugin by explicitly disabling the tags attribute, and adds a corresponding test to ensure this behavior. Tags are not needed in this model (which extends NetBoxModel) and cause reverse accessor conflicts with other Setting models (e.g. defined in other NetBox plugins)

Testing improvements:

  • Added a new test test_tags_disabled in netbox_diode_plugin/tests/test_models.py to verify that the tags attribute on the Setting model is disabled (set to None).

Model update:

  • Explicitly set the tags attribute to None in the Setting model within netbox_diode_plugin/models.py to disable tagging for this model.

Copy link

github-actions bot commented Sep 9, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3935 3558 90% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/models.py 100% 🟢
netbox_diode_plugin/tests/test_models.py 100% 🟢
TOTAL 100% 🟢

updated for commit: baab612 by action🐍

@mfiedorowicz mfiedorowicz merged commit 8e06e6d into develop Sep 9, 2025
7 checks passed
@mfiedorowicz mfiedorowicz deleted the fix-setting-model-disable-tags branch September 9, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants