Skip to content

refactor: use renderFunctionErrorPage from @netlify/dev-utils #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

keanu-a
Copy link
Contributor

@keanu-a keanu-a commented Jul 22, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #EX-366

Replaced all usages of renderErrorTemplate with renderFunctionErrorPage from @netlify/dev-utils, and deleted render-error-template.ts since now unused.

Ref: https://github.com/netlify/primitives/blob/main/packages/dev-utils/src/lib/errors.ts


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link

github-actions bot commented Jul 22, 2025

📊 Benchmark results

Comparing with 91b6c55

  • Dependency count: 1,076 (no change)
  • Package size: 295 MB (no change)
  • Number of ts-expect-error directives: 382 ⬇️ 0.79% decrease vs. 91b6c55

@keanu-a keanu-a closed this Jul 22, 2025
@keanu-a keanu-a reopened this Jul 24, 2025
@keanu-a keanu-a marked this pull request as ready for review July 29, 2025 15:11
@keanu-a keanu-a requested a review from a team as a code owner July 29, 2025 15:11
@keanu-a keanu-a merged commit 64f971d into main Aug 5, 2025
72 of 74 checks passed
@keanu-a keanu-a deleted the keanualoua/ex-366-use-renderfunctionerrorpage-in-netlifydev-utils branch August 5, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants