feat(@netlify/vite-plugin-react-router): add edge support #562
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Publint | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| branches: | ||
| - '**' | ||
| - '!release-please--**' | ||
| merge_group: | ||
| jobs: | ||
| publint: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - run: git config --global core.symlinks true | ||
| - uses: actions/checkout@v5 | ||
| with: | ||
| fetch-depth: 0 | ||
| - run: corepack enable pnpm | ||
| - name: Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/* | ||
| cache: 'pnpm' | ||
| - name: Install Deno | ||
| uses: denoland/setup-deno@v2 | ||
| with: | ||
| # Should satisfy the `DENO_VERSION_RANGE` from https://github.com/netlify/edge-bundler/blob/main/node/bridge.ts#L17 | ||
| deno-version: v2.2.4 | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
| - name: Build | ||
| run: pnpm run build:packages | ||
| - name: Publint | ||
| run: pnpm run --filter '@netlify/*' publint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| // All these `function-handler` exports are here for backwards compatibility. Now that we have separate exports | ||
| // for Function and Edge Functions, we should remove these exports in a future major version. | ||
| export type { GetLoadContextFunction, RequestHandler } from './runtimes/netlify-functions' | ||
| // Also, we never documented the `createRequestHandler` export, which has a very niche intended use case, and is not | ||
| // needed for the Edge Functions exports, so we should remove it as well. | ||
| export { createRequestHandler, netlifyRouterContext } from './runtimes/netlify-functions' | ||
|
|
||
| export { netlifyPlugin as default } from './plugin' |
|
Member
Author
There was a problem hiding this comment. File extracted as-is. Only change is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import type { AppLoadContext } from 'react-router' | ||
| import { type RouterContext, createContext, RouterContextProvider } from 'react-router' | ||
|
|
||
| /** | ||
| * A function that returns the value to use as `context` in route `loader` and `action` functions. | ||
| * | ||
| * You can think of this as an escape hatch that allows you to pass environment/platform-specific | ||
| * values through to your loader/action. | ||
| * | ||
| * NOTE: v7.9.0 introduced a breaking change when the user opts in to `future.v8_middleware`. This | ||
| * requires returning an instance of `RouterContextProvider` instead of a plain object. We have a | ||
| * peer dependency on >=7.9.0 so we can safely *import* these, but we cannot assume the user has | ||
| * opted in to the flag. | ||
| */ | ||
| export type GetLoadContextFunction<TNetlifyContext> = | ||
| | (( | ||
| request: Request, | ||
| context: TNetlifyContext, | ||
| ) => Promise<RouterContextProvider> | RouterContextProvider) | ||
| | ((request: Request, context: TNetlifyContext) => Promise<AppLoadContext> | AppLoadContext) | ||
|
|
||
| /** | ||
| * Creates a RouterContext that provides access to Netlify request context. | ||
| * Uses a Proxy to always read from the current `Netlify.context` value, which is always | ||
| * contextual to the in-flight request. | ||
| * | ||
| * @example context.get(netlifyRouterContext).geo?.country?.name | ||
| */ | ||
| export function createNetlifyRouterContext<TNetlifyContext>(): RouterContext< | ||
| Partial<TNetlifyContext> | ||
| > { | ||
| // We must use a singleton because Remix contexts rely on referential equality. | ||
| // We can't hook into the request lifecycle in dev mode, so we use a Proxy to always read from the | ||
| // current `Netlify.context` value, which is always contextual to the in-flight request. | ||
| return createContext<Partial<TNetlifyContext>>( | ||
| new Proxy( | ||
| // Can't reference `Netlify.context` here because it isn't set outside of a request lifecycle | ||
| {}, | ||
| { | ||
| get(_target, prop, receiver) { | ||
| return Reflect.get(Netlify.context ?? {}, prop, receiver) | ||
| }, | ||
| set(_target, prop, value, receiver) { | ||
| return Reflect.set(Netlify.context ?? {}, prop, value, receiver) | ||
| }, | ||
| has(_target, prop) { | ||
| return Reflect.has(Netlify.context ?? {}, prop) | ||
| }, | ||
| deleteProperty(_target, prop) { | ||
| return Reflect.deleteProperty(Netlify.context ?? {}, prop) | ||
| }, | ||
| ownKeys(_target) { | ||
| return Reflect.ownKeys(Netlify.context ?? {}) | ||
| }, | ||
| getOwnPropertyDescriptor(_target, prop) { | ||
| return Reflect.getOwnPropertyDescriptor(Netlify.context ?? {}, prop) | ||
| }, | ||
| }, | ||
| ), | ||
| ) | ||
| } | ||
|
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
identical to the Cloudflare one in the RR7 codebase... https://github.com/remix-run/react-router/blob/cb9a090316003988ff367bb2f2d1ef5bd03bd3af/integration/helpers/vite-plugin-cloudflare-template/app/entry.server.tsx