-
Notifications
You must be signed in to change notification settings - Fork 29
Update AWS parser for HTML emails #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Thank you for the PR. Let's get the tests cleared up and do you have an example of this new format? |
Hi @jvanderaa , |
It would need to be obfuscated and added for the test. I can add it or you can add it. It would be better to come from you since you would know what would be sensitive and can change it. Such as circuit IDs from whatever format to something that uses all 1s and a's in the format. |
here's the email without headers =20
=20
=20
=20
=20
=20
=20
=20`
=20
=20
=20
=20
=20
=20
=20
=20
=20
=20
=20
=20
=20
|
I've added the email to the docstring and broken the parsers into plaintext and html |
I think the expectations is to add the sample to the tests, here is a prior PR that updated the capabilities of an existing parser that should be a good guide: https://github.com/networktocode/circuit-maintenance-parser/pull/256/files |
Alright, I've got the tests in place and refactored the html parser into its own parser. |
Can I get an update on this? This is critical for us to have this functionality working soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one minor change that we shouldn't be making.
Apologies @beetanz was out of pocket most of last week due to travel. |
And the tests are not passing. |
Co-authored-by: Josh VanDeraa <[email protected]>
After updating the maintenance emails to go from AWS Health managed notifications they utilize an HTML format instead of plaintext. This was causing the parsing to fail. Adding support for the HTML emails from AWS health and maintaining previous code for plaintext (SNS) emails.