fix: loading indicator #15932
Merged
fix: loading indicator #15932
+32
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
Collaborator
Author
|
/backport to stable-3.34 |
alperozturk96
requested review from
AndyScherzinger,
ZetaTom and
tobiasKaminsky
alperozturk96
commented
Nov 10, 2025
|
|
||
| executorService.execute(() -> { | ||
| long currentSyncTime = System.currentTimeMillis(); | ||
| mSyncInProgress = true; |
Collaborator
Author
There was a problem hiding this comment.
Unused unnecessary duplicated logic that we have in FileDisplayActivity
alperozturk96
commented
Nov 10, 2025
| } | ||
| }.also { | ||
| mainThread { | ||
| mRefreshListLayout?.isRefreshing = false |
Collaborator
Author
There was a problem hiding this comment.
isRefreshing only set via pull-to-refresh since from #15529, no need to keep it as true.
Signed-off-by: alperozturk <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15932.apk |
AndyScherzinger
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Loading spinner stuck when user chooses the empty folder (from media → set media folder) and pull-to-refresh.