User-defined File Provider Domain Name on macOS

[Juoper]

No description provided.

[Rello]

Hello,

thank you for this contribution.
Can yo please describe what you want to achieve here?
Is it the folder name in the sidebar of finder? This is always set to the application name.

For any UI changes, also please provide screenshots

[i2h3]

Looks fine for me so far. However, to retain or increase consistent terminology with the underlying technology, I would kindly ask to update symbol names to refer to "display names" instead of "folder names".

For reference, see this property on file provider domains:
https://developer.apple.com/documentation/fileprovider/nsfileproviderdomain/displayname

I won't approve on my own because I cannot comment on the Qt part. I need feedback from the others in that regard.

On this occasion, I understand the reason why the user defaults access is implemented redundantly in fileprovidersettingscontroller_mac.mm and fileproviderdomainmanager_mac.mm. I guess it is a matter of time that this comes back like a boomerang. 😁 Maybe outsource this into a dedicated facility to have a consolidated, single implementation? I started moving things for the mapping between account and file provider domain identifiers recently, too.

[camilasan]

Please also use conventional commits convention: https://www.conventionalcommits.org/en/v1.0.0/

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[mgallien]

no activities
closing it
if you are still interested, feel free to reopen