feat(macOS): Add trash sync toggle for FileProvider virtual files#9264
feat(macOS): Add trash sync toggle for FileProvider virtual files#9264Flo-129 wants to merge 1 commit intonextcloud:masterfrom
Conversation
e7f29e2 to
2f103a7
Compare
Add user-facing option to control NSFileProviderDomain.supportsSyncingTrash property (macOS 13.0+). When enabled, deleted files appear in macOS Trash and server trash contents are visible in Finder. When disabled, Finder shows "Delete Immediately" option. Changes: - Add "Integrate macOS Trash" checkbox in FileProvider settings - Store per-account trash sync preference in NSUserDefaults - Implement domain reconfiguration (remove/add cycle) when setting changes - Add thread-safety with QMutex for domain registry access - Clean up unused socket-based communication code (replaced by XPC) Signed-off-by: Flo-129 <Flo-129@users.noreply.github.com>
2f103a7 to
7eba65a
Compare
|
Thank you for your new pull request! I will bring this up for discussion internally. 🤔 Personally, I think it is fine to have a checkbox for that feature toggle but it contradicts our design guidelines on the other hand. 😵💫 I need to check in with the others. |
|
Could ya'll approve workflows so we can test the builds from CI? |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9264.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hello @Flo-129 I want to update you, that the fix was implemented in a parallel PR. The reason is the deeper redesign work within the client which made merging this PR too complicated. the upcoming 4.0.5 will have the new trash handling already. There will be no flags anymore. The client will only put locally deleted items to the trash. No server deleted items; no items of others... thank you again for your contribution here... |
Summary
Changes
Test plan
Requirements