Skip to content

Add Config for Open With Capability #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Config for Open With Capability #4977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/Capabilities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use OCA\Richdocuments\Service\CapabilitiesService;
use OCP\App\IAppManager;
use OCP\Capabilities\ICapability;
use OCP\IConfig;
use OCP\IURLGenerator;

class Capabilities implements ICapability {
Expand Down Expand Up @@ -91,6 +92,7 @@ class Capabilities implements ICapability {
private ?array $capabilities = null;

public function __construct(
private IConfig $iconfig,
private AppConfig $config,
private CapabilitiesService $capabilitiesService,
private PermissionManager $permissionManager,
Expand Down Expand Up @@ -131,6 +133,20 @@ public function getCapabilities() {
$optionalMimetypes = array_diff($optionalMimetypes, ['application/pdf']);
}

$configuredOptionalMimetypes = $this->iconfig->getSystemValue('richdocuments_optional_mimetypes', null);
if (is_string($configuredOptionalMimetypes) && strtolower(trim($configuredOptionalMimetypes)) === 'all') {
$optionalMimetypes = array_merge($optionalMimetypes, $defaultMimetypes);
$defaultMimetypes = [];
} else if (is_array($configuredOptionalMimetypes)) {
$defaultMimetypes = array_diff($defaultMimetypes, $configuredOptionalMimetypes);
$optionalMimetypes = array_merge($optionalMimetypes, $configuredOptionalMimetypes);
}

// For an unknown reason there must be at least one mimetype
if (count($defaultMimetypes) === 0) {
$defaultMimetypes = ['dummy-by-nextcloud-office-for-no-default-mimetype'];
}

$this->capabilities = [
'richdocuments' => [
'version' => $this->appManager->getAppVersion('richdocuments'),
Expand Down
9 changes: 1 addition & 8 deletions src/file-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,7 @@ const openPdf = new FileAction({
},

enabled: (files) => {
if (files.length !== 1) {
return false
}

const isPdf = files[0].mime === 'application/pdf'
// Only enable the file action when files_pdfviewer is enabled
const optionalMimetypes = getCapabilities().mimetypesNoDefaultOpen
return isPdf && optionalMimetypes.includes('application/pdf')
return files.length === 1 && getCapabilities().mimetypesNoDefaultOpen.includes(files[0].mime)
},

exec: (file) => {
Expand Down