Skip to content

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jul 23, 2025

  • moving 'shareapi_allow_custom_tokens' to Lexicon.
  • adding the param (string) note: to __constructor() in Lexicon Entry
  • displaying optional note when setting via occ
image

@ArtificialOwl ArtificialOwl requested a review from a team as a code owner July 23, 2025 16:25
@ArtificialOwl ArtificialOwl requested review from come-nc, nfebe and salmart-dev and removed request for a team July 23, 2025 16:25
@ArtificialOwl ArtificialOwl force-pushed the feat/preset/custom-share-token branch 2 times, most recently from 94fb16c to 6bbaebd Compare July 23, 2025 18:12
@ArtificialOwl ArtificialOwl added the 2. developing Work in progress label Jul 23, 2025
@ArtificialOwl ArtificialOwl added this to the Nextcloud 32 milestone Jul 23, 2025
@ArtificialOwl ArtificialOwl force-pushed the feat/preset/custom-share-token branch from 6bbaebd to ecddfa9 Compare July 25, 2025 12:41
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are note and warning used?
Why are they part of definition and not in their own property?
Also looks like a use for Preset class is missing.

@ArtificialOwl ArtificialOwl force-pushed the feat/preset/custom-share-token branch from ecddfa9 to 59b8c38 Compare July 28, 2025 10:21
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Jul 28, 2025

Where are note and warning used?

I was thinking to display it on set:
image

Why are they part of definition and not in their own property?

I could, but I am afraid it will just make a lot of parameters in the constructor()
fixed.

Also looks like a use for Preset class is missing.

fixed.

@ArtificialOwl ArtificialOwl force-pushed the feat/preset/custom-share-token branch from 59b8c38 to 0c02fa0 Compare July 28, 2025 15:00
@ArtificialOwl
Copy link
Member Author

no warning, single note:
image

@ArtificialOwl ArtificialOwl force-pushed the feat/preset/custom-share-token branch from 0c02fa0 to 1b286ad Compare July 28, 2025 16:10
@ArtificialOwl ArtificialOwl requested a review from come-nc July 28, 2025 18:36
@ArtificialOwl ArtificialOwl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 28, 2025
@ArtificialOwl ArtificialOwl force-pushed the feat/preset/custom-share-token branch from 1b286ad to 3ceffe9 Compare July 29, 2025 09:15
@ArtificialOwl ArtificialOwl merged commit 51dc9f8 into master Jul 29, 2025
240 of 259 checks passed
@ArtificialOwl ArtificialOwl deleted the feat/preset/custom-share-token branch July 29, 2025 11:11
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants