-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(preset): add lexicon entry for custom share tokens #54064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94fb16c to
6bbaebd
Compare
6bbaebd to
ecddfa9
Compare
come-nc
reviewed
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are note and warning used?
Why are they part of definition and not in their own property?
Also looks like a use for Preset class is missing.
ecddfa9 to
59b8c38
Compare
59b8c38 to
0c02fa0
Compare
0c02fa0 to
1b286ad
Compare
come-nc
reviewed
Jul 29, 2025
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
1b286ad to
3ceffe9
Compare
come-nc
approved these changes
Jul 29, 2025
provokateurin
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


'shareapi_allow_custom_tokens'to Lexicon.note:to__constructor()in LexiconEntry