Login View Modernization #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a Placeholder property to the login and password fields
Added the authentication strategy type to the version string
…odernization # Conflicts: # Mage/UsernameFieldView.swift
Started on some LoginViewModel tests
…nDelegate instead
…out until next phase. Cleaning up other code to get rid of anything that is no longer needed. Also removing xib that are being replaced with SwiftUI
Removed commented-out code Added ViewInspector to the Test target
…to unreleased v0.10.3
|
NOTE: You may need to update your Swift Packages or do a |
danbenner-vega
previously approved these changes
Aug 6, 2025
|
@brentvegafederal Is this PR still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished the IDP login and LDAP login.
Added tests to verify the pieces work.