Fix build with PHP 8.5.0 Beta2 #1649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: - https://wiki.php.net/rfc/remove_disable_classes - php/php-src#12043 CC build/src/nxt_php_sapi-php85.o cc -c -pipe -fPIC -fvisibility=hidden -fno-strict-overflow -funsigned-char -std=gnu11 -O -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -fno-strict-aliasing -Wstrict-overflow=5 -Wmissing-prototypes -Werror -g -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -I src -I build/include \ -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -DNXT_ZEND_SIGNAL_STARTUP=1 \ -MMD -MF build/src/nxt_php_sapi-php85.dep -MT build/src/nxt_php_sapi-php85.o \ -o build/src/nxt_php_sapi-php85.o src/nxt_php_sapi.c src/nxt_php_sapi.c:714:37: error: no member named 'disable_classes' in 'struct _php_core_globals' 714 | &PG(disable_classes), | ~~~^~~~~~~~~~~~~~~~ /usr/local/include/php/main/php_globals.h:31:30: note: expanded from macro 'PG' 31 | # define PG(v) (core_globals.v) | ~~~~~~~~~~~~ ^ src/nxt_php_sapi.c:715:33: error: use of undeclared identifier 'zend_disable_class' 715 | zend_disable_class); | ^ 2 errors generated. gmake[1]: *** [build/Makefile:2107: build/src/nxt_php_sapi-php85.o] Error 1
|
Duplicate of #1647, closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
https://wiki.php.net/rfc/remove_disable_classes
core: Remove disable_classes INI setting php/php-src#12043
CC build/src/nxt_php_sapi-php85.o
cc -c -pipe -fPIC -fvisibility=hidden -fno-strict-overflow -funsigned-char -std=gnu11 -O -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -fno-strict-aliasing -Wstrict-overflow=5 -Wmissing-prototypes -Werror -g -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -I src -I build/include
-I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -DNXT_ZEND_SIGNAL_STARTUP=1
-MMD -MF build/src/nxt_php_sapi-php85.dep -MT build/src/nxt_php_sapi-php85.o
-o build/src/nxt_php_sapi-php85.o src/nxt_php_sapi.c
src/nxt_php_sapi.c:714:37: error: no member named 'disable_classes' in 'struct _php_core_globals'
714 | &PG(disable_classes),
| ~~~^~~~~~~~~~~~~~~~
/usr/local/include/php/main/php_globals.h:31:30: note: expanded from macro 'PG'
31 | # define PG(v) (core_globals.v)
| ~~~~~~~~~~~~ ^
src/nxt_php_sapi.c:715:33: error: use of undeclared identifier 'zend_disable_class'
715 | zend_disable_class);
| ^
2 errors generated.
gmake[1]: *** [build/Makefile:2107: build/src/nxt_php_sapi-php85.o] Error 1
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords in this PR's description or commit message.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).