Skip to content

Conversation

organom
Copy link
Member

@organom organom commented Oct 3, 2025

  • Update dependencies and runners
  • Generalize code and matrix definitions to make the steps look similar and more streamlined
  • Reduced amount of code by combining similar steps together
  • Fixes build for fedora (yum) to work with the latest changes of the development-tools group

Note: By some reason the PR seems to run a mix of the old and new action. Run of the action is available here: https://github.com/ngs-lang/ngs/actions/runs/18247616904

Relates to #523 where we should define what we want to test

@organom organom requested a review from ilyash-b October 3, 2025 11:24
Copy link
Contributor

@ilyash-b ilyash-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good but using latest requires justification. I don't like the builds breaking when they release new version.

@ilyash-b
Copy link
Contributor

ilyash-b commented Oct 4, 2025

Also, anything we can do about these? (shows on this pull request page)

image

@organom
Copy link
Member Author

organom commented Oct 4, 2025

Overall looks good but using latest requires justification. I don't like the builds breaking when they release new version.

Currently the builds were almost stopping because the images were too old and being deprecated.
Since it has been proven we'll only be updating the actions when they fail, I would prefer the builds to break as soon as the NGS installation is not compatible with any latest versions of an OS, because it'll make us look into it and fix. As an example: Fedora installation was failing for a while already and we only picked it now - current version of fedora is 42, we were testing for 34 and 35...

Can i move ubuntu and debian also to latest ? :D

@organom
Copy link
Member Author

organom commented Oct 4, 2025

Also, anything we can do about these? (shows on this pull request page)
image

Thats the old versions (had a NOTE on the PR, they somehow run all of it in the PR), here you have the ones that are part of the new code: https://github.com/ngs-lang/ngs/actions/runs/18247616904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants