Skip to content

Don't join fkey table when linq comparison with composite id #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 20, 2025

Conversation

jeff-hagen
Copy link
Contributor

@jeff-hagen jeff-hagen commented Nov 27, 2024

When referencing a foreign key composite-id in Linq, don't add a join with the fkey table to the resulting SQL (make behavior consistent with the same query in HQL). Fixes #3676

@jeff-hagen jeff-hagen changed the title #3628 - Don't join when linq comparison with composite id Don't join when linq comparison with composite id Nov 27, 2024
@jeff-hagen jeff-hagen changed the title Don't join when linq comparison with composite id Don't join fkey table when linq comparison with composite id Dec 27, 2024
@jeff-hagen
Copy link
Contributor Author

@fredericDelaporte would you mind taking a look at my PR?

@fredericDelaporte fredericDelaporte added this to the 5.6 milestone Jul 13, 2025
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About *.sql files, file encoding changes are not encouraged. They are harder to review and break somewhat the history when looking for significant changes.

This said, as the encoding was not consistent with the 2012 files, let it be.

LGTM.

@jeff-hagen
Copy link
Contributor Author

OK. Thank you.

About *.sql files, file encoding changes are not encouraged. They are harder to review and break somewhat the history when looking for significant changes.

This said, as the encoding was not consistent with the 2012 files, let it be.

LGTM.

@fredericDelaporte fredericDelaporte merged commit c8e1129 into nhibernate:master Jul 20, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When referencing a composite-id in Linq, the fkey table is wrongly joined
2 participants