Skip to content

Conversation

@gquintard
Copy link
Contributor

This reverts commit 2b18abe.

On 8.0, I'm getting:

/usr/bin/install -c -m 644 vmod_dynamic.vcc ./vmod_vcs_version.txt vtc/admin_health.vtc vtc/layer.vtc vtc/layer_probe.vtc vtc/layer_reload.vtc vtc/r00107.vtc vtc/stale_obj.vtc vtc/test01.vtc vtc/test02.vtc vtc/test03.vtc vtc/test04.vtc vtc/test05.vtc vtc/test06.vtc vtc/test07.vtc vtc/test08.vtc vtc/test09.vtc vtc/test10.vtc vtc/test11.vtc vtc/test12.vtc vtc/test13.vtc vtc/test14.vtc vtc/via.vtc vtc/via_uds.vtc vtc/nogetdns/resolver_init_error.vtc '/usr/share/doc/vmod-dynamic'
/bin/mkdir -p '/usr/lib/varnish/vmods'
install: can't stat './vmod_vcs_version.txt': No such file or directory

vmod_vcs_version.txt doesn't seem to be generated anymore, and reverting the original commit seems to do the job.

This reverts commit 2b18abe.

On 8.0, I'm getting:

```
/usr/bin/install -c -m 644 vmod_dynamic.vcc ./vmod_vcs_version.txt vtc/admin_health.vtc vtc/layer.vtc vtc/layer_probe.vtc vtc/layer_reload.vtc vtc/r00107.vtc vtc/stale_obj.vtc vtc/test01.vtc vtc/test02.vtc vtc/test03.vtc vtc/test04.vtc vtc/test05.vtc vtc/test06.vtc vtc/test07.vtc vtc/test08.vtc vtc/test09.vtc vtc/test10.vtc vtc/test11.vtc vtc/test12.vtc vtc/test13.vtc vtc/test14.vtc vtc/via.vtc vtc/via_uds.vtc vtc/nogetdns/resolver_init_error.vtc '/usr/share/doc/vmod-dynamic'
/bin/mkdir -p '/usr/lib/varnish/vmods'
install: can't stat './vmod_vcs_version.txt': No such file or directory
```

`vmod_vcs_version.txt` doesn't seem to be generated anymore, and
reverting the original commit seems to do the job.
@gquintard
Copy link
Contributor Author

note: I'll circumvent it for 8.0 docker image release by using my fork, but I would prefer keep this here repository as the source of truth

@nigoroll nigoroll closed this in 570990d Dec 7, 2025
@nigoroll
Copy link
Owner

nigoroll commented Dec 7, 2025

@gquintard Let me guess, you are using.... the github "download as ZIP"? <rant>I really think promoting this as a "default way" is such a bad bad idea of gh. We have dist archives for good reason, and they solve these problems and many more. And now what, everyone is using this and we need to make compromises just to accomodate everyone's expectations</rant>

I have carried over the handling of "no vcs_version" by @cartoush, so now you get:

$ ./bootstrap
...
configure: WARNING: Building without version control metadata - vmod_vcs_version.txt will be unavailable
...
$ make
WARNING: Neither git nor vmod_vcs_version.txt found.
	 Please build from a git repo or from a dist archive.

Now if you go this path, your docker images will be missing git revision information, which is, IMHO, vital for troubleshooting. So I strongly recommend to build your container images from git or dist archives.

@nigoroll
Copy link
Owner

nigoroll commented Dec 7, 2025

fixups: 32b8c13 aeec99f

@gquintard
Copy link
Contributor Author

I usually rely on dust tarballs, but a compatible one wasn't available at the time, so I went to the next best thing.

Using git directly is a bit more annoying, but I can update the script to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants