Skip to content

Conversation

@barracuda156
Copy link

This PR implements initial support for Darwin ppc32 and adds minor fixes for ppc64.

Building will require this to be merged too: nim-lang/csources_v1#7

@barracuda156
Copy link
Author

2 failing checks do not seem related to either Darwin PPC or my patches. For example:

error: invalid argument '-std=c99' not allowed with 'C++'
error: invalid argument '-std=c99' not allowed with 'C++'
error: invalid argument '-std=c99' not allowed with 'C++'
Error: execution of an external compiler program 'g++ -c -std=gnu++14 -funsigned-char  -w -fmax-errors=3 -fpermissive -pthread -std=c99   -I/Users/runner/work/1/s/lib -I/Users/runner/work/1/s/tests/compiler -o /Users/runner/work/1/s/nimcache/tests/compiler/tasm.nim_2c5f2cba9af7f92986d3de1e753f3faa/@m..@s..@slib@[email protected] /Users/runner/work/1/s/nimcache/tests/compiler/tasm.nim_2c5f2cba9af7f92986d3de1e753f3faa/@m..@s..@slib@[email protected]' failed with exit code: 1

That file has not been modified, and -std=c99 was not added anywhere in my patches.

@Varriount
Copy link
Contributor

I'll merge this once the csources PR is merged.

@Varriount
Copy link
Contributor

@Araq Is there anything else that needs to be done in this PR?

@end

@if macosx or freebsd or openbsd:
cc = clang
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this affects the existing OSX and BSD targets!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Araq Thank you for pointing this out! I will fix that. Of course, BSD should not be affected in any way.

Give me few days please, I am just back to Taiwan and building gcc12 across several machines. I will deal with this and csources PR later this week, I hope.

;;
*darwin* )
myos="macosx"
CC="clang"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Araq I assume that for MacOS hardcoding Clang does no good, since for x86 and aarch64 Clang is the default compiler anyway (both in Xcode and Macports, so nothing changes), while for ppc Clang should never be invoked (hardcoding breaks the build).
But if there is a reason to hardcode it, then it must exclude ppc and ppc64.

@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Sep 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This pull request is stale because it has been open for 1 year with no activity. Contribute more commits on the pull request and rebase it on the latest devel, or it will be closed in 30 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Staled PR/issues; remove the label after fixing them label Oct 4, 2023
@barracuda156
Copy link
Author

Forgot about this. Sorry.

I will give this another go next week.

@github-actions github-actions bot removed the stale Staled PR/issues; remove the label after fixing them label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request is stale because it has been open for 1 year with no activity. Contribute more commits on the pull request and rebase it on the latest devel, or it will be closed in 30 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Staled PR/issues; remove the label after fixing them label Oct 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

This pull request has been marked as stale and closed due to inactivity after 395 days.

@github-actions github-actions bot closed this Nov 3, 2024
@barracuda156
Copy link
Author

This needs to be re-done. I will see if the thing can be built now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Requires Araq To Merge PR should only be merged by Araq stale Staled PR/issues; remove the label after fixing them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants