-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Implement support for Darwin PPC #20373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
2 failing checks do not seem related to either Darwin PPC or my patches. For example: That file has not been modified, and |
|
I'll merge this once the csources PR is merged. |
|
@Araq Is there anything else that needs to be done in this PR? |
| @end | ||
|
|
||
| @if macosx or freebsd or openbsd: | ||
| cc = clang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this affects the existing OSX and BSD targets!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Araq Thank you for pointing this out! I will fix that. Of course, BSD should not be affected in any way.
Give me few days please, I am just back to Taiwan and building gcc12 across several machines. I will deal with this and csources PR later this week, I hope.
| ;; | ||
| *darwin* ) | ||
| myos="macosx" | ||
| CC="clang" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Araq I assume that for MacOS hardcoding Clang does no good, since for x86 and aarch64 Clang is the default compiler anyway (both in Xcode and Macports, so nothing changes), while for ppc Clang should never be invoked (hardcoding breaks the build).
But if there is a reason to hardcode it, then it must exclude ppc and ppc64.
|
This pull request is stale because it has been open for 1 year with no activity. Contribute more commits on the pull request and rebase it on the latest devel, or it will be closed in 30 days. Thank you for your contributions. |
|
Forgot about this. Sorry. I will give this another go next week. |
|
This pull request is stale because it has been open for 1 year with no activity. Contribute more commits on the pull request and rebase it on the latest devel, or it will be closed in 30 days. Thank you for your contributions. |
|
This pull request has been marked as stale and closed due to inactivity after 395 days. |
|
This needs to be re-done. I will see if the thing can be built now. |
This PR implements initial support for Darwin
ppc32and adds minor fixes forppc64.Building will require this to be merged too: nim-lang/csources_v1#7