Skip to content

remove unnecessay conds for nilable strings/seqs #25086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

remove unnecessay conds for nilable strings/seqs #25086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/std/private/miscdollars.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ template tupleObjectDollar*[T: tuple | object](result: var string, x: T) =
result.add(": ")
count.inc
when compiles($value):
when value isnot string and value isnot seq and compiles(value.isNil):
when compiles(value.isNil):
if value.isNil: result.add "nil"
else: result.addQuoted(value)
else:
Expand Down
2 changes: 1 addition & 1 deletion lib/system/dollars.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ proc collectionToString[T](x: T, prefix, separator, suffix: string): string =
else:
result.add(separator)

when value isnot string and value isnot seq and compiles(value.isNil):
when compiles(value.isNil):
# this branch should not be necessary
if value.isNil:
result.add "nil"
Expand Down
Loading