Skip to content

Allow local paths to be used for package specification. #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow local paths to be used for package specification. #1241

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0279167
Omit cloning if the package is on local
Jul 7, 2024
88fda43
Attempt to interpret as a file path before the package name
Jul 7, 2024
ea2ed50
Allow relative paths to be specified
Jul 7, 2024
940b24b
Without the `--withDependencies` option, behaves the same as before
Jul 7, 2024
3883ff9
Merge branch 'master' into pr-1241
ringabout Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/nimblepkg/download.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,15 +531,19 @@ proc getDevelopDownloadDir*(url, subdir: string, options: Options): string =
let url = url.removeTrailingSlash
let subdir = subdir.removeTrailingSlash

let uri = parseUri(url)

let downloadDirName =
if subdir.len == 0:
parseUri(url).path.splitFile.name
uri.path.splitFile.name
else:
subdir.splitFile.name

result =
if options.action.path.isAbsolute:
options.action.path / downloadDirName
elif options.action.withDependencies and uri.scheme == "file":
uri.path
else:
getCurrentDir() / options.action.path / downloadDirName

Expand Down Expand Up @@ -577,6 +581,9 @@ proc getDownloadInfo*(pv: PkgTuple, options: Options,
if pv.name.isURL:
let (url, metadata) = getUrlData(pv.name)
return (checkUrlType(url), url, metadata)
elif dirExists(pv.name):
let (url, metadata) = getUrlData("file://" & expandFilename(pv.name))
return (checkUrlType(url), url, metadata)
else:
var pkg = initPackage()
if getPackage(pv.name, options, pkg, ignorePackageCache):
Expand Down