-
Notifications
You must be signed in to change notification settings - Fork 39
sem: varargs now have and conform to a specification #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
- parameter passing - typed ast construction
also rename/relocate tests to more appropriate location
- use blocks to document each test - reorder and group tests more logically - note tests that should work with `knownIssue` comments
- sketch of all missing tests identified thus far - plan for test coverage - inventory of existing tests - document questions and answers for future and current direction This will be used to create the initial test spec for varargs.
- relatively fine grained split of knownIssues for easier fixing - cross-reference knownIssues between parent and knownIssue tests - remove corresponding sketch tests from `tvarargs` - disable `tvarargs` so the `lang_callable/varags` category can be run
remove corresponding tests from tvarargs.
until it's fixed going to be marking lots of tests as known issue
- ensure varargs parameter is inferrable - add tests to disallow type parameter being set to varargs
|
One of the things blocking this PR is that the core matchesAux loop needs to work on a per formal parameter basis instead of per argument as it is now. This allows for the progress of matching against formals to be controlled more precisely. As part of that I believe one of the things that needs to happen is to move default parameter handling/setting to happen in |
4447e88 to
5808ef6
Compare
Summary
varargparameters and to a lesser extent the pragmaDetails
Notes for Reviewers
sigmatchin one gotvarargsmanual.rst) to indicate new behaviour and future directionsigmatch.matchesAuxwhich contains the parameter handling- [ ] any related updates/changes