Skip to content

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 8, 2025

No description provided.

@Mic92 Mic92 force-pushed the fix-image-script branch 6 times, most recently from 2daa230 to e115440 Compare May 8, 2025 08:16
@Mic92 Mic92 force-pushed the fix-image-script branch from e115440 to c0565d6 Compare May 8, 2025 09:01
@Mic92 Mic92 enabled auto-merge May 8, 2025 09:05
@Mic92 Mic92 added this pull request to the merge queue May 8, 2025
Merged via the queue into master with commit c7e0b00 May 8, 2025
2 checks passed
@Mic92 Mic92 deleted the fix-image-script branch May 8, 2025 09:09
@Mic92 Mic92 changed the title diskoImageScript: fix compat with nixpkgs-unstable diskoImageScript: improve documentation for testing inside a VM May 8, 2025
@zackw
Copy link

zackw commented May 8, 2025

Hey, thanks for improving the documentation here! Can I make just one small additional suggestion: please add instructions for making your test VM overlay-mount /nix/store from the host, so people don't have to use copyNixStore = true?

@Mic92
Copy link
Member Author

Mic92 commented May 8, 2025

Hey, thanks for improving the documentation here! Can I make just one small additional suggestion: please add instructions for making your test VM overlay-mount /nix/store from the host, so people don't have to use copyNixStore = true?

Not quite sure what this means. Currently this just tests the built image. Why would we share state with the host system?

@Mic92
Copy link
Member Author

Mic92 commented May 8, 2025

What you are proposing sounds more like the qemu-vm.nix profile.

@zackw
Copy link

zackw commented May 8, 2025

Unless #778 gets merged (and currently I don't think it should be merged, for reasons discussed over there), the vmWithDisko output is not useful to me. You added nice clear instructions for how to use the disk image produced by diskoImageScript for testing, in the same way one might use vmWithDisko. But because I'm only using it for testing, I would like those instructions to explain how to share /nix/store with the host, so I don't have to twiddle my thumbs while it's copied into the disk image, repeat on every test cycle. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants