Skip to content

Filter by prefix on no exact match #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmattia merged 2 commits into from
Aug 11, 2026
Merged

Filter by prefix on no exact match #442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6262718
Filter by prefix on no exact match
nmattia Aug 11, 2026
ee60525
Clarify comment
nmattia Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Niv/Cli.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,11 +386,11 @@ filterPackages :: Sources -> Maybe PackagePattern -> Sources
filterPackages (unSources -> sources) mPat = Sources $ case mPat of
-- no pattern: return all packages
Nothing -> sources
-- pattern (filter) provided: match exact
-- pattern (filter) provided: return an exact match; if no exact match, match by prefix
Just (PackagePattern pat) -> case HMS.lookup (PackageName pat) sources of
Just exact -> HMS.singleton (PackageName pat) exact
Nothing ->
HMS.filterWithKey (\k _ -> unPackageName k == pat) sources
HMS.filterWithKey (\k _ -> pat `T.isPrefixOf` (unPackageName k)) sources

parseCmdUpdate :: Opts.ParserInfo (NIO ())
parseCmdUpdate =
Expand Down