Skip to content

test: only show overridden env in child process failures #60556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
+16 −2
Merged

test: only show overridden env in child process failures #60556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions test/common/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,22 @@ function expectSyncExit(caller, spawnArgs, {
console.error(`${tag} status = ${child.status}, signal = ${child.signal}`);

const error = new Error(`${failures.join('\n')}`);
if (spawnArgs[2]) {
error.options = spawnArgs[2];
if (typeof spawnArgs[2] === 'object' && spawnArgs[2] !== null) {
const envInOptions = spawnArgs[2].env;
// If the env is overridden in the spawn options, include it in the error
// object for easier debugging.
if (typeof envInOptions === 'object' && envInOptions !== null && envInOptions !== process.env) {
// Only include the environment variables that are different from
// the current process.env to avoid cluttering the output.
error.options = { ...spawnArgs[2], env: {} };
for (const key of Object.keys(envInOptions)) {
if (envInOptions[key] !== process.env[key]) {
error.options.env[key] = spawnArgs[2].env[key];
}
}
} else {
error.options = spawnArgs[2];
}
}
let command = spawnArgs[0];
if (Array.isArray(spawnArgs[1])) {
Expand Down
Loading