-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
docs(license): clarify license section and add contributor note #60590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(license): clarify license section and add contributor note #60590
Conversation
6960c86 to
c242638
Compare
|
Thanks for the review @UlisesGascon 🙏 |
c242638 to
538fa82
Compare
|
@Madhu696969 we need an additional work to make the linter happy, but almos there 👍 |
|
Thanks for the feedback @UlisesGascon 🙏 Please have a quick look when you get a chance. Appreciate your time and review! 😊 |
|
@UlisesGascon @BethGriggs |
|
Hi @UlisesGascon — all checks have passed and approval is completed. Could you please merge this when convenient? Thanks! 🙏 |
|
Hi @BethGriggs 👋 |
|
Hey @Madhu696969! No need to keep pinging 😄 The PR looks good and has everything needed to land. Let’s give others a bit of time to review it too... it won’t get lost, don’t worry! |
Commit Queue failed- Loading data for nodejs/node/pull/60590 ✔ Done loading data for nodejs/node/pull/60590 ----------------------------------- PR info ------------------------------------ Title docs(license): clarify license section and add contributor note (#60590) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Madhu696969:docs-label-guidance -> nodejs:main Labels doc, author ready Commits 3 - doc: clarify license section and add contributor note - fix(docs): wrap long lines in license section to satisfy remark-lint - fix(docs): remove markdownlint disable comment and rewrap lines under… Committers 1 - Madhu <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60590 Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Beth Griggs <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60590 Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Beth Griggs <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 05 Nov 2025 13:17:10 GMT ✔ Approvals: 2 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/60590#pullrequestreview-3429547973 ✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/60590#pullrequestreview-3423457402 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60590 From https://github.com/nodejs/node * branch refs/pull/60590/merge -> FETCH_HEAD ✔ Fetched commits as 33b1574cbf65..4723115aff84 -------------------------------------------------------------------------------- Auto-merging README.md [main abf92f2245] doc: clarify license section and add contributor note Author: Madhu <[email protected]> Date: Wed Nov 5 18:45:43 2025 +0530 1 file changed, 10 insertions(+), 5 deletions(-) Auto-merging README.md [main 4be545e9bc] fix(docs): wrap long lines in license section to satisfy remark-lint Author: Madhu <[email protected]> Date: Thu Nov 6 15:04:06 2025 +0530 1 file changed, 5 insertions(+), 5 deletions(-) Auto-merging README.md [main 827c3f7f8a] fix(docs): remove markdownlint disable comment and rewrap lines under 120 chars Author: Madhu <[email protected]> Date: Thu Nov 6 17:57:56 2025 +0530 1 file changed, 2 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. (node:2200) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc: clarify license section and add contributor notehttps://github.com/nodejs/node/actions/runs/19403820522 |
|
Hi @UlisesGascon, |
|
Landed in 6f0d104 |
This PR refines the License section in README.md for better clarity and consistency.
It clarifies that Node.js uses the MIT License, references external dependencies more clearly,
and adds a short note reminding contributors to ensure license compliance when submitting changes.