Skip to content

Conversation

@Madhu696969
Copy link
Contributor

This PR refines the License section in README.md for better clarity and consistency.
It clarifies that Node.js uses the MIT License, references external dependencies more clearly,
and adds a short note reminding contributors to ensure license compliance when submitting changes.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 5, 2025
@Madhu696969 Madhu696969 force-pushed the docs-label-guidance branch 2 times, most recently from 6960c86 to c242638 Compare November 5, 2025 14:05
@Madhu696969
Copy link
Contributor Author

Thanks for the review @UlisesGascon 🙏
I’ve updated the commit message format and cleaned up the Markdown spacing as per the CI checks.

@UlisesGascon
Copy link
Member

@Madhu696969 we need an additional work to make the linter happy, but almos there 👍

README.md
909:123 warning Unexpected `122` character line, expected at most `120` characters, remove `2` characters  maximum-line-length remark-lint
911:132 warning Unexpected `131` character line, expected at most `120` characters, remove `11` characters maximum-line-length remark-lint

@Madhu696969
Copy link
Contributor Author

Thanks for the feedback @UlisesGascon 🙏
I’ve addressed the remark-lint warnings by wrapping the long lines in the License section — all Markdown lines are now within the 120-character limit.

Please have a quick look when you get a chance. Appreciate your time and review! 😊

@Madhu696969
Copy link
Contributor Author

@UlisesGascon @BethGriggs
I’ve addressed the latest feedback by removing the unnecessary markdownlint disables and rewrapping lines under 120 chars.
All CI checks have passed ✅
Could you please take another quick look and re-approve when convenient? 🙏

@Madhu696969
Copy link
Contributor Author

Hi @UlisesGascon — all checks have passed and approval is completed. Could you please merge this when convenient? Thanks! 🙏

@Madhu696969
Copy link
Contributor Author

Hi @BethGriggs 👋
The PR has already been approved by @UlisesGascon and all checks have passed successfully ✅
Could you please merge it when you get a chance? Thank you for your time and review 🙏

@UlisesGascon UlisesGascon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 8, 2025
@UlisesGascon
Copy link
Member

Hey @Madhu696969! No need to keep pinging 😄

The PR looks good and has everything needed to land. Let’s give others a bit of time to review it too... it won’t get lost, don’t worry!

@UlisesGascon UlisesGascon added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 16, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/60590
✔  Done loading data for nodejs/node/pull/60590
----------------------------------- PR info ------------------------------------
Title      docs(license): clarify license section and add contributor note (#60590)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Madhu696969:docs-label-guidance -> nodejs:main
Labels     doc, author ready
Commits    3
 - doc: clarify license section and add contributor note
 - fix(docs): wrap long lines in license section to satisfy remark-lint
 - fix(docs): remove markdownlint disable comment and rewrap lines under…
Committers 1
 - Madhu <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/60590
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60590
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 05 Nov 2025 13:17:10 GMT
   ✔  Approvals: 2
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/60590#pullrequestreview-3429547973
   ✔  - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/60590#pullrequestreview-3423457402
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 60590
From https://github.com/nodejs/node
 * branch                  refs/pull/60590/merge -> FETCH_HEAD
✔  Fetched commits as 33b1574cbf65..4723115aff84
--------------------------------------------------------------------------------
Auto-merging README.md
[main abf92f2245] doc: clarify license section and add contributor note
 Author: Madhu <[email protected]>
 Date: Wed Nov 5 18:45:43 2025 +0530
 1 file changed, 10 insertions(+), 5 deletions(-)
Auto-merging README.md
[main 4be545e9bc] fix(docs): wrap long lines in license section to satisfy remark-lint
 Author: Madhu <[email protected]>
 Date: Thu Nov 6 15:04:06 2025 +0530
 1 file changed, 5 insertions(+), 5 deletions(-)
Auto-merging README.md
[main 827c3f7f8a] fix(docs): remove markdownlint disable comment and rewrap lines under 120 chars
 Author: Madhu <[email protected]>
 Date: Thu Nov 6 17:57:56 2025 +0530
 1 file changed, 2 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
(node:2200) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: clarify license section and add contributor note

PR-URL: #60590
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>

[detached HEAD 28c467bf78] doc: clarify license section and add contributor note
Author: Madhu <[email protected]>
Date: Wed Nov 5 18:45:43 2025 +0530
1 file changed, 10 insertions(+), 5 deletions(-)
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix(docs): wrap long lines in license section to satisfy remark-lint

PR-URL: #60590
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>

[detached HEAD e16766ab4a] fix(docs): wrap long lines in license section to satisfy remark-lint
Author: Madhu <[email protected]>
Date: Thu Nov 6 15:04:06 2025 +0530
1 file changed, 5 insertions(+), 5 deletions(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix(docs): remove markdownlint disable comment and rewrap lines under 120 chars

PR-URL: #60590
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>

[detached HEAD faa20e7008] fix(docs): remove markdownlint disable comment and rewrap lines under 120 chars
Author: Madhu <[email protected]>
Date: Thu Nov 6 17:57:56 2025 +0530
1 file changed, 2 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/19403820522

@Madhu696969
Copy link
Contributor Author

Hi @UlisesGascon,
I noticed the commit-queue failed.
Please let me know if I need to rebase or make any changes.
Thank you!

@UlisesGascon UlisesGascon added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit 6f0d104 into nodejs:main Nov 17, 2025
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6f0d104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants