Skip to content

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Nov 5, 2025

Otherwise, it can be virtually impossible to debug where these types of errors originate from.

Otherwise, it can be virtually impossible to debug where these types
of errors originate from.
@addaleax addaleax requested a review from jasnell November 5, 2025 15:53
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 5, 2025
@addaleax addaleax added the fs Issues and PRs related to the fs subsystem / file system. label Nov 5, 2025
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2025
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.56%. Comparing base (fa9918e) to head (0d18d20).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60593      +/-   ##
==========================================
+ Coverage   88.55%   88.56%   +0.01%     
==========================================
  Files         704      704              
  Lines      208077   208083       +6     
  Branches    40084    40086       +2     
==========================================
+ Hits       184269   184297      +28     
+ Misses      15833    15820      -13     
+ Partials     7975     7966       -9     
Files with missing lines Coverage Δ
src/dataqueue/queue.cc 64.70% <100.00%> (+0.06%) ⬆️
src/node_file.h 77.55% <ø> (ø)
src/node_file.cc 75.61% <64.28%> (+<0.01%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2025
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 2703db7 into nodejs:main Nov 7, 2025
87 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2703db7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants