Skip to content

test: fix flaky test-http2-close-while-writing #61804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Han5991 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Draft

test: fix flaky test-http2-close-while-writing #61804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-http2-close-while-writing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ server.listen(0, common.mustCall(() => {
});
client_stream = client.request({ ':method': 'POST' });
client_stream.on('close', common.mustCall(() => {
client.close();
client.destroy();
Copy link
Member

@lpinca lpinca Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still not clear to me why this callback

node/lib/internal/http2/core.js

Lines 2192 to 2196 in 6710c00

const writeCallback = (err) => {
waitingForWriteCallback = false;
writeCallbackErr = err;
done();
};
is not called. See #58252.

Copy link
Contributor Author

@Han5991 Han5991 Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your suggestion. Using destroy() feels more natural here given the test scenario involves an abrupt disconnection while writing.

Copy link
Contributor Author

@Han5991 Han5991 Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with the test method in issue 58252

image

Copy link
Member

@lpinca lpinca Feb 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides the bug, the callback should be called.

server.close();
}));
client_stream.resume();
Expand Down
Loading