Skip to content

sqlite: handle stmt invalidation#61877

Open
araujogui wants to merge 1 commit intonodejs:mainfrom
araujogui:sqlite-invalidate
Open

sqlite: handle stmt invalidation#61877
araujogui wants to merge 1 commit intonodejs:mainfrom
araujogui:sqlite-invalidate

Conversation

@araujogui
Copy link
Member

Fixes #61819

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (94b1f66) to head (a430473).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61877      +/-   ##
==========================================
- Coverage   91.77%   89.72%   -2.06%     
==========================================
  Files         338      675     +337     
  Lines      140064   204812   +64748     
  Branches    22045    39358   +17313     
==========================================
+ Hits       128543   183760   +55217     
- Misses      11298    13330    +2032     
- Partials      223     7722    +7499     
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.94% <100.00%> (ø)
src/node_sqlite.h 80.39% <ø> (ø)

... and 456 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +2547 to 2548
stmt->reset_generation_++;
int r = sqlite3_reset(stmt->statement_);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this combo might be better as an inline reset method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite: statement iterator state is corrupted by coincident statement execution

3 participants

Comments