-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix the position of the footer links #8003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #8003 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 95 95
Lines 8308 8308
Branches 214 214
=======================================
Hits 6063 6063
Misses 2244 2244
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we just put it in the i18n?
I think the same, I believe we should put it in the i18n. |
Signed-off-by: Sebastian Beltran <[email protected]>
Fast-tracking these changes, I'm going to sleep so feel free to merge it if you agree. |
Lighthouse Results
|
I also wonder why the Security Policy link is on the right, shouldn't it be on the left? And OpenJS Foundation on the right? |
Before we were doing a hack of slicing the array and I wanted to avoid that. |
This change was introduced in #8001. I thought the change was intentional to keep the OpenJS Foundation on the left side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the positioning of a copyright symbol by moving the OpenJS Foundation link from the beginning of the footer links array to the end. Based on the provided screenshots, this change ensures the copyright symbol appears in the correct visual position within the footer layout.
- Reorders footer navigation links to fix copyright symbol placement
- Moves OpenJS Foundation link to the end of the footerLinks array
Description
Before:

After:

Validation
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.