Skip to content

fix the position of the footer links #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 22, 2025
Merged

fix the position of the footer links #8003

merged 5 commits into from
Jul 22, 2025

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Jul 21, 2025

Description

Before:
imagen

imagen

After:
imagen

imagen

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 22, 2025 2:28am

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.97%. Comparing base (16c6d1e) to head (522bac5).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8003   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files          95       95           
  Lines        8308     8308           
  Branches      214      214           
=======================================
  Hits         6063     6063           
  Misses       2244     2244           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just put it in the i18n?

@bjohansebas
Copy link
Member Author

Why don't we just put it in the i18n?

I think the same, I believe we should put it in the i18n.

@bjohansebas bjohansebas marked this pull request as ready for review July 21, 2025 02:08
@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 02:08
@bjohansebas bjohansebas requested a review from a team as a code owner July 21, 2025 02:08
Copilot

This comment was marked as outdated.

@bjohansebas
Copy link
Member Author

Fast-tracking these changes, I'm going to sleep so feel free to merge it if you agree.

Copy link
Contributor

github-actions bot commented Jul 21, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🔴 66 🔗
/en/about 🟢 100 🟢 97 🟢 100 🔴 58 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🔴 61 🔗
/en/download 🟠 88 🟢 100 🟢 100 🔴 66 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🔴 69 🔗

@ovflowd
Copy link
Member

ovflowd commented Jul 21, 2025

I also wonder why the Security Policy link is on the right, shouldn't it be on the left? And OpenJS Foundation on the right?

@ovflowd
Copy link
Member

ovflowd commented Jul 21, 2025

Before we were doing a hack of slicing the array and I wanted to avoid that.

@bjohansebas
Copy link
Member Author

I also wonder why the Security Policy link is on the right, shouldn't it be on the left? And OpenJS Foundation on the right?

This change was introduced in #8001. I thought the change was intentional to keep the OpenJS Foundation on the left side.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the positioning of a copyright symbol by moving the OpenJS Foundation link from the beginning of the footer links array to the end. Based on the provided screenshots, this change ensures the copyright symbol appears in the correct visual position within the footer layout.

  • Reorders footer navigation links to fix copyright symbol placement
  • Moves OpenJS Foundation link to the end of the footerLinks array

@bjohansebas bjohansebas changed the title fix: move copyright symbol to the correct element fix the position of the footer links Jul 22, 2025
@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Jul 22, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 22, 2025
@bjohansebas bjohansebas added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit b4006c5 Jul 22, 2025
14 checks passed
@bjohansebas bjohansebas deleted the fix-footer branch July 22, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants