Skip to content

Conversation

@liranmauda
Copy link
Contributor

Explain the changes

Remove root secret from pod env variables

(cherry picked from commit 0154df1)

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/DFBUGS-4410

Signed-off-by: Ben <[email protected]>
(cherry picked from commit 0154df1)
@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

if r.NooBaa.Spec.ExternalPgSSLUnauthorized {
c.Env[j].Value = "true"
}
case "NOOBAA_ROOT_SECRET":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correcly, we are not removing any envs that are already set on the Sts\deployment. We should probably see if this env is set and explictly remove/reset it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants