-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add documentation for trusted publishers #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I rebased the commits into a single one. |
reggi
reviewed
Jul 17, 2025
...ations/integrating-npm-with-external-services/using-private-packages-in-a-ci-cd-workflow.mdx
Outdated
Show resolved
Hide resolved
steiza
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! One minor nit.
content/packages-and-modules/securing-your-code/trusted-publishers.mdx
Outdated
Show resolved
Hide resolved
nishantms
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
dhei
approved these changes
Jul 18, 2025
owlstronaut
approved these changes
Jul 18, 2025
karenjli
approved these changes
Jul 18, 2025
karenjli
reviewed
Jul 28, 2025
…hers.mdx Co-authored-by: Karen Li <[email protected]>
karenjli
approved these changes
Jul 28, 2025
nishantms
approved these changes
Jul 28, 2025
saquibkhan
approved these changes
Jul 30, 2025
leobalter
pushed a commit
that referenced
this pull request
Aug 4, 2025
<!-- What / Why --> <!-- Describe the request in detail. What it does and why it's being changed. --> The internal links added in #1674 followed the on-disk paths and did not respect that the URL paths use a different scheme, as explained in https://github.com/npm/documentation/blob/4c574b89e23515d8411e5ec52624d6a932b874e0/CONTRIBUTING.md#urls: > ### URLs > Note that for backward compatibility reasons, the on-disk paths are not precisely identical to the URLs for the documentation. To keep URLs expressive but still short, intermediate directories are removed from a page's URL. > > (...) > > You might (understandably) expect the page "Creating Node.js modules" to be URL-wise beneath `contributing-packages-to-the-registry`, but unfortunately, you would be wrong. To keep URLs short, the intermediate folder paths are removed from pages, so "Creating Node.js modules" becomes `https://docs.npmjs.com/creating-node-js-modules`. Also see https://github.com/npm/documentation/blob/4c574b89e23515d8411e5ec52624d6a932b874e0/CONTENT-MODEL.md#content-structure: > ## Content structure > > Docs are grouped by topic. > > - Top-level doc set (Example: https://docs.npmjs.com/packages-and-modules) > - Categories (Example: https://docs.npmjs.com/packages-and-modules/introduction-to-packages-and-modules) > - **Articles (Example: https://docs.npmjs.com/about-packages-and-modules)** As a result, these links did not work at https://docs.npmjs.com/. This PR fixes them. ## References Related to #1674 (all links fixed in this PR were introduced there) <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new documentation for trusted publishers, to be released soon.
References
Related to npm/cli#8336
Replaces #1673 (now using a branch without a fork)