Skip to content

Conversation

@FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Oct 3, 2025

Current Behavior

There is no first-party Maven support for Nx

Expected Behavior

Maven Support is ready for usage.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Error Error Oct 20, 2025 7:39pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit ab33bbc
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/68f6ad680a81b60008a0ef38
😎 Deploy Preview https://deploy-preview-32947--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@FrozenPandaz FrozenPandaz marked this pull request as draft October 3, 2025 14:30
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Oct 3, 2025

View your CI Pipeline Execution ↗ for commit ab33bbc

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 14m 59s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-20 22:06:10 UTC

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Failed to publish a PR release of this pull request, triggered by @FrozenPandaz.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/18285305766

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Failed to publish a PR release of this pull request, triggered by @FrozenPandaz.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/18285666201

Clarify that all phases get targets (either with goals or as noop), while only CI phase targets are conditionally created based on having goals or being the verify phase.
Split lifecycle processing into two focused functions:
- createRegularPhaseTarget(): Creates regular phase targets with dependencies
- createCiPhaseTarget(): Creates CI phase targets with dependencies

Process executes in two passes within each lifecycle:
1. First pass creates all regular phase targets
2. Second pass creates CI phase targets (depends on first pass state)

This maintains exact behavior while improving code clarity and separation of concerns.
Extract magic strings to named constants (MVND_COMMAND, MVNW_COMMAND, MVN_COMMAND, MVNW_FILENAME).
Use Kotlin's let scope function instead of null check and double-bang operator.
Extract mvnd detection into dedicated isMvndAvailable() function.
Simplify detectMavenCommand() logic and remove redundant timing code.
Cleanup in NxProjectAnalyzer.kt, MojoAnalyzer.kt, and PathFormatter.kt:
- Remove unused variables and dead code
- Simplify conditional logic
- Extract magic strings to constants
- Improve code clarity and formatting
Replace xmldom ^0.6.0 with @xmldom/xmldom ^0.8.10, which is the maintained,
secure fork of xmldom. No API changes required - same interface.
Remove unused imports, simplify type definitions, and improve code clarity
in index.ts, maven-data-cache.ts, nodes.ts, and types.ts.
@github-actions
Copy link
Contributor

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-32947-e6aa0c1
Release details 📑
Published version 0.0.0-pr-32947-e6aa0c1
Triggered by @FrozenPandaz
Branch maven-plugin
Commit e6aa0c1
Workflow run 18658600692

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

serveTargetName?: string;
verbose?: boolean;
atomizeTests?: boolean;
minTestClassesForAtomization?: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

nxProject.put("name", projectName)
nxProject.put("root", root)
nxProject.put("projectType", projectType)
nxProject.put("sourceRoot", "${root}/src/main/java")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data class?

Remove unused code from NxTargetFactory.kt, simplify PathFormatter.kt logic,
and clean up type definitions in types.ts.
@FrozenPandaz FrozenPandaz marked this pull request as ready for review October 20, 2025 21:43
@FrozenPandaz FrozenPandaz requested review from a team and MaxKless as code owners October 20, 2025 21:43
@FrozenPandaz FrozenPandaz changed the title feat(maven): introduce maven plugin WIP feat(maven): introduce maven plugin Oct 20, 2025
@FrozenPandaz FrozenPandaz merged commit 135019b into master Oct 20, 2025
12 of 14 checks passed
@FrozenPandaz FrozenPandaz deleted the maven-plugin branch October 20, 2025 22:52
FrozenPandaz added a commit that referenced this pull request Oct 21, 2025
## Current Behavior

The Java landing page at nx.dev/java only mentions Gradle support and
indicates that Maven support is coming soon.

## Expected Behavior

The Java landing page should reflect that Maven is now available
alongside Gradle.

https://nx-dev-git-mvn-follow-nrwl.vercel.app/java

## Related Issue(s)

Updates the documentation to reflect the Maven plugin introduced in
#32947

---

**Changes:**
- Updated hero section to state "Nx supports both Gradle and Maven"
- Modified getting started instructions to mention both `@nx/gradle` and
`@nx/maven`
- Updated features description to include Maven builds
- Combined Gradle and Maven documentation links into a single "Learn
More" section with buttons for both
- Updated call-to-action links to point to
`/docs/technologies/java/{gradle,maven}/introduction`
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants