Add winget upgrades command
#1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`winget upgrade` has two modes: * No parameters (at all) lists available upgrades * Any parameter attempts to match and upgrade a package Much like `winget list`, `winget upgrade` prints a spinner, then a table, and then additionally a footer. The `winget list` completions handle output through `detect columns --guess` and return structured data. Presumably because `detect columns --guess` does not work on `winget upgrade`, no output handling was done until now. 1. Split off trimLoadingSymbol as a common function between two, now three, commands 2. Implement a separate command `winget upgrades` instead of handling `winget upgrade` because of overloaded behavior complicating implementation Now, `winget upgrades` can be used to get structured data of available upgrades, while `winget upgrade` behaves like before, without parameters has text output, and with parameters upgrades packages. While introducing a separate command is not strictly completions [for external commands], this one is very close to the completions, logic, and use cases. Keeping it close will help discovery and future development which may integrate returning structured data into the "normal" completions.
untested, unverified
|
ok, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winget upgradehas two modes:Much like
winget list,winget upgradeprints a spinner, then a table, and then additionally a footer.The
winget listcompletions handle output throughdetect columns --guessand return structured data.Presumably because
detect columns --guessdoes not work onwinget upgrade, no output handling was done until now.winget upgradesinstead of handlingwinget upgradebecause of overloaded behavior complicating implementationNow,
winget upgradescan be used to get structured data of available upgrades, whilewinget upgradebehaves like before, without parameters has text output, and with parameters upgrades packages.While introducing a separate command is not strictly completions [for external commands], this one is very close to the completions, logic, and use cases. Keeping it close will help discovery and future development which may integrate returning structured data into the "normal" completions.
I was not able to test for “no updates” output.