fix: allow custom Enter keybindings in vi mode #982
+17
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ReedlineEvent::EnterProblem
Previously, the Enter key in vi mode was handled before checking custom keybindings:
This meant users could not override Enter behavior in
vi_insertorvi_normalmodes. Custom keybindings like abbreviation expansion menus would work with Space but not Enter.Solution
Check keybindings first via
find_binding(), fall back to default Enter behavior only if no custom binding exists. This matches how emacs mode already handles Enter.flowchart TD A[Enter key pressed in vi mode] --> B{Custom keybinding exists?} B -->|Yes| C[Execute custom binding] B -->|No| D[Default: ReedlineEvent::Enter]Testing
Tested with nushell's abbreviation expansion menu - Enter now correctly triggers the menu before submitting, matching Space behavior.
Note
Made with claude code.