Skip to content

fix: ignore capacitor paths if present #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NRodriguezcuellar
Copy link
Contributor

@NRodriguezcuellar NRodriguezcuellar commented Jun 5, 2025

πŸ”— Linked issue

resolves #647

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

These changes add deeper integration to capacitor enabled projects, initial setup is done to adjust the typescript config according to if a capacitor config file is present and the path that it has set, so it can be excluded for type checking

Copy link

netlify bot commented Jun 5, 2025

βœ… Deploy Preview for friendly-lamington-fb5690 ready!

Name Link
πŸ”¨ Latest commit d1263d2
πŸ” Latest deploy log https://app.netlify.com/projects/friendly-lamington-fb5690/deploys/688a0b674fbd070008e39e6d
😎 Deploy Preview https://deploy-preview-770--friendly-lamington-fb5690.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

❌ Patch coverage is 51.66667% with 29 lines in your changes missing coverage. Please review.
βœ… Project coverage is 46.17%. Comparing base (957b3c6) to head (d1263d2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parts/capacitor.ts 45.28% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   46.72%   46.17%   -0.56%     
==========================================
  Files          11       12       +1     
  Lines         672      732      +60     
  Branches       34       47      +13     
==========================================
+ Hits          314      338      +24     
- Misses        358      394      +36     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NRodriguezcuellar
Copy link
Contributor Author

i could also add the functionality from #469 as it seems it was never completed? @danielroe

@danielroe
Copy link
Collaborator

@NRodriguezcuellar that would be a really nice idea - maybe useful for a future PR?

@danielroe danielroe changed the title feat: integrate with capacitor config fix: ignore capacitor paths if present Jul 30, 2025
@danielroe danielroe merged commit 60fbb6a into nuxt-modules:main Jul 30, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type checking after adding iOS and Android Apps
2 participants