Skip to content

Conversation

nathanchase
Copy link
Contributor

@nathanchase nathanchase commented May 16, 2025

πŸ”— Linked issue

(#1843)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This modifies the ImageModifiers interface to support custom provider modifiers by adding an index signature.

@nathanchase nathanchase requested a review from danielroe as a code owner May 16, 2025 01:05
Copy link

pkg-pr-new bot commented May 16, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@1844

commit: f9d90c2

@danielroe
Copy link
Member

danielroe commented May 16, 2025

I think instead of this (which removes type safety for modifiers) we should amend useImage to respect the generic provider type.

@nathanchase
Copy link
Contributor Author

Ok, I've updated the PR to preserve type-safety based on the selected provider. Please review and let me know what you think! Thanks, @danielroe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants