Skip to content

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 14, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR aims to run tests on Windows in CI, to avoid potential regressions.

related: nuxt/ecosystem-ci#15

@danielroe danielroe self-assigned this Oct 14, 2024
@userquin
Copy link
Member

userquin commented Oct 20, 2024

Maybe you can use normalize + <root> hack in tests: https://github.com/unjs/unimport/blob/main/test/vue-directives.test.ts#L82-L84

@userquin
Copy link
Member

userquin commented Dec 6, 2024

We don't need to normalize the id, mlly requires a file and so we only need to use pathToFileURL here https://github.com/nuxt/module-builder/pull/399/files#diff-fb19954ad9c19d5004b1b36f4322497cb03dce0b6cf3377e2cf16873950c71a8R123:

const distFile = await resolvePath(pathToFileURL(resolved.id).href)

I'm checking the failing test on my local:

imagen

imagen

@danielroe danielroe changed the title ci: run test suite on windows fix(build): handle windows path names Dec 6, 2024
@danielroe danielroe merged commit b2b4a90 into main Dec 6, 2024
2 checks passed
@danielroe danielroe deleted the ci/windows branch December 6, 2024 13:22
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielroe danielroe mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants