Skip to content

ci: use pnpm/setup and devEngines #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 8 commits into from
Sep 9, 2026
+19 −32
Merged

ci: use pnpm/setup and devEngines #2418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
382cc03
ci: use `pnpm/setup` and `devEngines`
danielroe Sep 8, 2026
a9ca959
ci: keep `packageManager` and declare honest node range
danielroe Sep 9, 2026
c5c6ac0
ci: pin `pnpm/setup` to v2.1.0
danielroe Sep 9, 2026
5aaaa6e
ci: let `pnpm/setup` run the install
danielroe Sep 9, 2026
b86e335
fix: raise declared node range above rolldown's engines floor
danielroe Sep 9, 2026
2ae9034
chore: remove specified version in workflows
danielroe Sep 9, 2026
edc7c85
chore: remove other locations
danielroe Sep 9, 2026
de78238
remove require-lockfile
danielroe Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .github/workflows/bundle-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,11 @@ jobs:
path: .bundle-base
persist-credentials: false
ref: ${{ github.event.pull_request.base.sha }}
- run: corepack enable
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
- uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0
with:
node-version: lts/-1
cache: pnpm
cache: true
cache-dependency-path: .bundle-base/pnpm-lock.yaml
- name: Install base dependencies
working-directory: .bundle-base
run: pnpm install --frozen-lockfile
working-directory: .bundle-base
- name: Prepare the base revision
working-directory: .bundle-base
run: pnpm nuxt prepare
Expand Down Expand Up @@ -78,14 +74,10 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
persist-credentials: false
- run: corepack enable
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
- uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0
with:
node-version: lts/-1
cache: pnpm
cache: true
cache-dependency-path: pnpm-lock.yaml
- name: Install PR dependencies
run: pnpm install --frozen-lockfile
- name: Prepare the PR revision
run: pnpm nuxt prepare
- name: Analyze the PR bundle
Expand Down
21 changes: 6 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- run: corepack enable
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
- uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0
with:
node-version: lts/-1
cache: "pnpm"
- run: pnpm install
cache: true
- run: pnpm nuxt prepare
- run: pnpm lint

unit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- run: corepack enable
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
- uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0
with:
node-version: lts/-1
cache: "pnpm"
- run: pnpm install
cache: true
- run: pnpm nuxt prepare
- run: pnpm vitest run
env:
Expand All @@ -44,11 +38,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- run: corepack enable
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
- uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0
with:
node-version: lts/-1
cache: "pnpm"
- run: pnpm install
cache: true
- run: pnpm nuxt prepare
- run: pnpm typecheck
5 changes: 1 addition & 4 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,8 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
persist-credentials: false
- run: corepack enable
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
- uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0
with:
node-version: lts/-1
- run: pnpm install --frozen-lockfile
- run: pnpm exec playwright install
- name: Run Playwright E2E tests
run: pnpm test:browser
Expand Down
7 changes: 7 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
"name": "nuxt.com",
"version": "0.3.11",
"packageManager": "pnpm@12.3.4",
"devEngines": {
"runtime": {
"name": "node",
"version": "^22.12.0",
"onFail": "warn"
}
},
"type": "module",
"scripts": {
"dev": "nuxt dev --ui-only",
Expand Down