feat(defineShortcuts): add layoutIndependent option for keyboard shortcuts
#4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 29, 2025 14:29
Add optional layoutIndependent flag to defineShortcuts composable that enables layout-agnostic keyboard shortcuts by using KeyboardEvent.code instead of KeyboardEvent.key. When enabled, shortcuts work consistently across different keyboard layouts (Arabic, Hebrew) by matching physical key positions rather than character values. Usage: - layoutIndependent: false (default) - uses e.key for character-based matching - layoutIndependent: true - uses e.code for physical key matching Breaking change: When layoutIndependent is true, shortcut definitions must use physical key codes (e.g., 'ctrl_KeyS' instead of 'ctrl_s'). Closes: nuxt#2293
commit: |
al1maher
changed the title
layoutIndependent option for keyboard shortcuts
|
I would very like to have this implemented! |
|
@smarroufin What do you think of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional layoutIndependent flag to defineShortcuts composable that enables layout-agnostic keyboard shortcuts by using KeyboardEvent.code instead of KeyboardEvent.key.
🔗 Linked issue
Closes: #2293
❓ Type of change
📚 Description
When enabled, shortcuts work consistently across different keyboard layouts (Arabic, Hebrew) by matching physical key positions rather than character values.
Usage:
📝 Checklist