feat(FormField): add required field support across form components
#4534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamincanac
changed the title
required field support across form components
benjamincanac
approved these changes
Jul 16, 2025
commit: |
romhml
reviewed
Jul 18, 2025
There was a problem hiding this comment.
Thanks @rdjanuar! Could you add a test for the required inheritance here? https://github.com/nuxt/ui/blob/v3/test/components/FormField.spec.ts#L97
rdjanuar
commented
Jul 19, 2025
test/components/FormField.spec.ts
Outdated
Comment on lines
26
to
47
| async function renderFormField(options: { | ||
| props: Partial<FormFieldProps> | ||
| inputComponent: typeof inputComponents[number] | ||
| }) { | ||
| return await mountSuspended(UFormField, { | ||
| props: options.props, | ||
| return await mountSuspended(UForm, { | ||
| slots: { | ||
| default: { | ||
| // @ts-expect-error - Object literal may only specify known properties, and setup does not exist in type | ||
| setup: () => ({ inputComponent: options.inputComponent }), | ||
| setup: () => ({ | ||
| formFieldProps: options.props, | ||
| inputComponent: options.inputComponent | ||
| }), | ||
| components: { | ||
| UFormField, | ||
| USelectMenu, | ||
| UForm, | ||
| ...inputComponents | ||
| }, | ||
| template: ` | ||
| <component :is="inputComponent" /> | ||
| <UFormField v-bind="formFieldProps"> | ||
| <component :is="inputComponent" :model-value="'0'" /> | ||
| </UFormField> |
There was a problem hiding this comment.
we should refactor renderFormField to fit with required test because on reka-ui, there`s certain condition to show element that has required attr like select or input
rdjanuar
commented
Jul 19, 2025
docs/app/components/content/examples/input-number/InputNumberFormFieldExample.vue
Outdated
Show resolved
Hide resolved
romhml
approved these changes
Jul 25, 2025
|
@rdjanuar Would you mind fixing the conflicts? 😬 |
i get this error while updating snapshot, any idea how to fix it ? @benjamincanac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #4529, maybe #3882
❓ Type of change
📚 Description
📝 Checklist