Skip to content

Use more public cuDF APIs in cudf_helpers - #2211

Open
mroeschke wants to merge 4 commits into
nv-morpheus:branch-25.06from
mroeschke:cln/cudf/table_with_metadata
Open

Use more public cuDF APIs in cudf_helpers#2211
mroeschke wants to merge 4 commits into
nv-morpheus:branch-25.06from
mroeschke:cln/cudf/table_with_metadata

Conversation

@mroeschke

Copy link
Copy Markdown
Contributor

Description

  • cudf.DataFrame.from_pylibcudf now accepts a table_with_metadata object removing most all of the logic from make_table_from_table_with_metadata
  • Avoid accessing APIs from cudf.core which is considered "private"
  • Simplified some logic that didn't seem as necessary anymore (maybe necessary when there was a RAPIDS 24.12 patch here)

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mroeschke
mroeschke requested a review from a team as a code owner April 14, 2025 21:57
@copy-pr-bot

copy-pr-bot Bot commented Apr 14, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@morpheus-bot-test morpheus-bot-test Bot moved this to Review - Ready for Review in Morpheus Boards Apr 14, 2025
@willkill07 willkill07 added non-breaking Non-breaking change improvement Improvement to existing functionality labels Apr 16, 2025
@willkill07

Copy link
Copy Markdown
Member

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Apr 16, 2025

Copy link
Copy Markdown

/ok to test

@willkill07, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@willkill07

Copy link
Copy Markdown
Member

/ok to test ef31441

@mroeschke

Copy link
Copy Markdown
Contributor Author

Thanks @willkill07. I'll look into the failures

@willkill07

Copy link
Copy Markdown
Member

/ok to test e2a0b1d

@dagardner-nv

Copy link
Copy Markdown
Contributor

@mroeschke what version of cuDF do we need to be on for these new APIs?

@mroeschke

Copy link
Copy Markdown
Contributor Author

These APIs, the important one being cudf.DataFrame.from_pylibcudf, is new as of 25.06. Thanks for the reminder.

@dagardner-nv

Copy link
Copy Markdown
Contributor

These APIs, the important one being cudf.DataFrame.from_pylibcudf, is new as of 25.06. Thanks for the reminder.

Ahh! OK, we're still on 25.02, this one will need to be placed on hold until we're able to update our version of cuDF.

@mroeschke

Copy link
Copy Markdown
Contributor Author

No problem, thanks for following up. Feel free to ping when Morpheus has upgraded and I can re-test this PR

@mbudge

mbudge commented Jan 13, 2026

Copy link
Copy Markdown

#2317

@dagardner-nv dagardner-nv self-assigned this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

Status: Review - Ready for Review

Development

Successfully merging this pull request may close these issues.

4 participants