Skip to content

feat: Enhances breakpoint editing #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

blehrer
Copy link

@blehrer blehrer commented May 13, 2025

The keymapping <leader>B (in kickstart.plugins.debug) is now configured to guide users through the process of adding a condition, hitCondition, and logMessage to a breakpoint.

This also allows attributes that have already been set to be edited, instead of having to start from scratch each time you want to update one of these fields.

These breakpoints will persist for the duration of the session.

Tested with v0.11.1

The keymapping `<leader>B` is now configured to guide users through the
process of adding a `condition`, `hitCondition`, and `logMessage` to a
breakpoint.
@blehrer
Copy link
Author

blehrer commented May 13, 2025

small note to the reviewers: h:dap.toggle_breakpoint() misspells variable names. Compare docs to src.

Copy link
Contributor

@oriori1703 oriori1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a like a great addition 😄

I commented about a few suggestions / fixes

Instead of creating an empty object to fill, only create one if no match is found.

Co-authored-by: Ori Perry <[email protected]>
blehrer and others added 2 commits July 4, 2025 09:21
@blehrer blehrer requested a review from oriori1703 July 4, 2025 16:26
Copy link
Contributor

@oriori1703 oriori1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

oriori1703 added a commit to oriori1703/kickstart-modular.nvim that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants