fix: handle winborder in neovim-0.11 #649
Conversation
This means that the user may override the global window border for all windows for which the border wasn't explicitly set. For the scrollbar and the scrollbar thumb, we don't want any border. In the past we achieved that by now specifying a border, but with winborder, the user may set the border and then the scrollbar looks broken. So now we explicitly say that we want no border on these two windows, fixing the issue.
emmanueltouzery
changed the title
|
works for me |
|
works for me. |
|
works for me |
…/plenary.nvim#649) because cmp windows use this setting too
|
I've been using this change locally on both my mac and windows system and it works well. Is there any concern for continuing support for neovim <0.11? As-is I think this change would break installs still using 0.10 or less. |
|
I don't believe this change breaks anything for 0.10 or less. In fact I wrote in the PR:
What makes you think it would break anything? |
|
Oh okay, nice coverage I missed that in the description. The change looks like it modified the defaults which is why I thought it would alter 0.10 behavior. |
|
Plenary relied on the previous defaults, 0.11 changed the defaults, with the change we now enforce was plenary actually always wanted. Imho |
|
Are there plans to merge this anytime soon? |
neovim 0.11 introduced winborder: neovim/neovim#31074
This means that the user may override the global window border for all windows for which the border wasn't explicitly set.
In the past we achieved borderless windows by not specifying a border, but with winborder, the user may set the border and then the UI looks broken. So now we explicitly say that we want no border on the windows where we intended it so.
I tested this commit on neovim 0.10.2 as well, without issues.
To reproduce the issue on neovim 0.11, run:
and for instance open telescope, which is a plenary-using plugin showing the issue.
fixes nvim-telescope/telescope.nvim#3436
note that i do NOT have a clear vision of the whole plenary popups code, i just found the two windows that got a border with winborder that shouldn't, and enforced no border.